Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): [KDL6-276] update CR on configmap change #1137

Merged

Conversation

igzor
Copy link
Collaborator

@igzor igzor commented Jan 22, 2025

Motivation and Context

This simplifies the logic of the ConfigMap Watcher functionality that updates CR when the CR templates in ConfigMaps change. The previously applied input fields are now stored within the CRs itself and are re-applied upon update.

This allows for the propagation of MinIO credentials upon update.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have created tests for my code changes, and the tests are passing.
  • I have executed the pre-commit hooks locally.
  • I have updated the documentation accordingly.
  • The commit message follows our guidelines: https://github.com/konstellation-io/kdl-server/blob/main/CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • My change requires a change to the documentation (create a new issue if the documentation has not been updated).

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

MinIO credentials are lost when CR template updates.

Closes #

What is the new behavior?

MinIO credentials are propagated when CR template updates.

Does this PR introduce a breaking change?

  • Yes
  • No

Now, CRD and CR require extra field specs.inputData

Other information

Copy link

Quality Gate Failed Quality Gate failed for 'kdl-server-app-api'

Failed conditions
75.1% Coverage on New Code (required ≥ 80%)
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@igzor igzor changed the base branch from main to feat/KDL6-46-data-privacy January 22, 2025 13:00
@igzor igzor merged commit 8d8f74f into feat/KDL6-46-data-privacy Jan 23, 2025
11 of 13 checks passed
@igzor igzor deleted the feat/KDL6-276-update-cr-on-configmap-change branch January 23, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants